Dropdown: remove dependency to role="menu", role="listbox" a and li elements => fix keyboard navigation #19864
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per migration documentation in 4d8d8bd:
Per #19034 (comment) role="menu" should have been dropped.
This PR:
role="menu"
orrole="listbox"
and rely on the classdropdown-menu
insteada
element for the dropdown-item and rely on the classdropdown-item
insteadli
elementsAll this problems affected only the keyboard navigation in the dropdown.
With this modification the javascript now matches the markup in the documentation.
The keyboard navigation works again now in dropdowns.