Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown: remove dependency to role="menu", role="listbox" a and li elements => fix keyboard navigation #19864

Closed
wants to merge 4 commits into from

Conversation

pvdlg
Copy link
Contributor

@pvdlg pvdlg commented May 9, 2016

Per migration documentation in 4d8d8bd:

  • Rebuilt dropdown styles and markup to provide easy, built-in support for <a> and <button> based dropdown items.
  • Dropdown items now require .dropdown-item.

Per #19034 (comment) role="menu" should have been dropped.

This PR:

  • Remove the dependency to role="menu" or role="listbox" and rely on the class dropdown-menu instead
  • Remove the dependency to the a element for the dropdown-item and rely on the class dropdown-item instead
  • Remove the necessity to wrap dropdown-item in li elements

All this problems affected only the keyboard navigation in the dropdown.
With this modification the javascript now matches the markup in the documentation.
The keyboard navigation works again now in dropdowns.

@pvdlg
Copy link
Contributor Author

pvdlg commented Jan 4, 2017

Opened #21535 that fix the conflict.
For some reason I couldn't update this PR as I might have delete the source branch.

@pvdlg pvdlg closed this Jan 4, 2017
@jump020305
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants